Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Memory leak in /sync when creating RoomStreamTokens with no instance_map #13286

Closed
squahtx opened this issue Jul 15, 2022 · 2 comments · Fixed by #13352
Closed

Memory leak in /sync when creating RoomStreamTokens with no instance_map #13286

squahtx opened this issue Jul 15, 2022 · 2 comments · Fixed by #13352
Labels
A-Sync defects related to /sync S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Milestone
Revisit: Next Month

Comments

@squahtx
Copy link
Contributor

squahtx commented Jul 15, 2022

Constructing an empty frozendict leaks memory: Marco-Sulla/python-frozendict#60

We do a lot of that during /sync, when we create RoomStreamTokens with no instance_map.

Possibly the cause of #12160?
@squahtx squahtx added A-Sync defects related to /sync S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 15, 2022
@squahtx squahtx mentioned this issue Jul 15, 2022
Closed
@squahtx squahtx added this to the Revisit: Next Month milestone Jul 15, 2022
@squahtx
Copy link
Contributor Author

squahtx commented Jul 15, 2022

Also affects StateFilters, since we make use of frozendicts there:

synapse/synapse/storage/state.py

Line 47 in 7c6b220

class StateFilter:

@clokep
Copy link
Member

clokep commented Jul 21, 2022

Looks like frozendict v2.3.3 contains the fix. 🎉

This was referenced Jul 21, 2022
Merged
Closed
@DMRobertson DMRobertson mentioned this issue Mar 14, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Sync defects related to /sync S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
Revisit: Next Month
Development

Successfully merging a pull request may close this issue.

Update locked frozendict version to 2.3.3 matrix-org/synapse
2 participants
@clokep @squahtx