This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
JSONSchema Validation For Filters #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
synapse/api/filtering.py
Outdated
| "timeline": { | ||
| "$ref": "#/definitions/room_event_filter" | ||
| }, | ||
| "accpount_data": { |
pik
force-pushed
the
filter-validation
branch
5 times, most recently
from
918a9d9
to
41cc3da
Compare
|
looks good to me, just requires a rebase |
|
@matrixbot ok to test |
* add invalid filter tests Signed-off-by: pik <alexander.maznev@gmail.com>
Signed-off-by: pik <alexander.maznev@gmail.com>
* use a valid filter in rest/client/v2_alpha test Signed-off-by: pik <alexander.maznev@gmail.com>
Signed-off-by: pik <alexander.maznev@gmail.com>
|
Thanks! |
richvdh
added a commit
that referenced
this pull request
Oct 24, 2018
Fixes a bug introduced in #1783 which meant that single backslashes were not allowed in event field filters. The intention here is to allow single-backslashes, but disallow double-backslashes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the that the
room_event_filterschema supplied by the spec does not actually function in all cases e.g. ##1782 - should probably be addressed, adding test cases and either by adding the missing functionality or limiting the schema.