Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We tell you to pip install ... even if you are using the debian packages, which will break peoples' systems #3743

Closed
richvdh opened this issue Aug 22, 2018 · 3 comments
Closed

We tell you to pip install ... even if you are using the debian packages, which will break peoples' systems #3743

richvdh opened this issue Aug 22, 2018 · 3 comments
Labels
A-Docs things relating to the documentation

Comments

@richvdh
Copy link
Member

richvdh commented Aug 22, 2018 •
edited
Loading

There are several instances of this:

synapse/synapse/app/__init__.py

Line 29 in 52ec6e9

" pip install --upgrade --force \"%s\"" % (e.dependency,),

synapse/synapse/config/repository.py

Line 30 in 49af402

pip install lxml

@richvdh richvdh mentioned this issue Aug 22, 2018
Closed
richvdh added a commit to matrix-org/package-synapse-debian that referenced this issue Aug 23, 2018
@richvdh
Add recommendations on python-lxml and python-psycopg2
2423d4c 
lxml is required for URL previews; this will help mitigate
matrix-org/synapse#3743.

psycopg2 is obviously required for anyone who isn't just playing.
richvdh added a commit to matrix-org/package-synapse-debian that referenced this issue Aug 23, 2018
@richvdh
Add recommendations on python-lxml and python-psycopg2
3c0540c 
lxml is required for URL previews; this will help mitigate
matrix-org/synapse#3743.

psycopg2 is obviously required for anyone who isn't just playing.
@richvdh
Copy link
Member Author

richvdh commented Aug 24, 2018 •
edited
Loading

to be clear: people using the debian packages should be using apt-get install python-<package>, not pip

@neilisfragile neilisfragile added the A-Docs things relating to the documentation label Aug 28, 2018
@richvdh richvdh changed the title We tell you to pip install lxml even if you are using the debian packages, which will break peoples' systems We tell you to pip install ... even if you are using the debian packages, which will break peoples' systems Sep 6, 2018
@richvdh
Copy link
Member Author

richvdh commented Sep 6, 2018

The easiest way to fix these might actually be to patch them out in the debian packaging

@richvdh richvdh mentioned this issue Sep 6, 2018
Closed
richvdh added a commit to matrix-org/package-synapse-debian that referenced this issue Sep 7, 2018
@richvdh
Avoid telling people to install packages with pip
b335400 
Fixes: matrix-org/synapse#3743
@richvdh
Copy link
Member Author

richvdh commented Sep 7, 2018

fixed as of 0.33.4-1mx1.

@richvdh richvdh closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Docs things relating to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neilisfragile @richvdh