Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

logcontext warnings during startup #3820

Closed
richvdh opened this issue Sep 7, 2018 · 1 comment
Closed

logcontext warnings during startup #3820

richvdh opened this issue Sep 7, 2018 · 1 comment
Assignees
@richvdh
Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics. z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Sep 7, 2018

A bunch of mau-related code was introduced in 0.33.3 ish (#3708, #3662, and many others) which runs a bunch of database code during startup without yielding or otherwise managing logcontexts, and hence ends up leaking logcontexts into the reactor and emitting scary-looking warnings in the logs:

2018-09-07 11:18:43,101 - synapse.util.logcontext - 431 - WARNING - - Unexpected logging context: main@7fd0fb976c08 is not sentinel
@richvdh richvdh mentioned this issue Sep 7, 2018
Merged
@hawkowl hawkowl added the A-Logging Synapse's logs (structured or otherwise). Not metrics. label Sep 14, 2018
@neilisfragile neilisfragile added the z-p2 (Deprecated Label) label Oct 5, 2018
@neilisfragile neilisfragile self-assigned this Oct 5, 2018
richvdh added a commit that referenced this issue Oct 20, 2018
@richvdh
Run MAU queries as background processes
a6f421e 
Fixes #3820
@richvdh richvdh mentioned this issue Oct 20, 2018
Merged
@richvdh richvdh assigned richvdh and unassigned neilisfragile Oct 20, 2018
@richvdh
Copy link
Member Author

richvdh commented Oct 25, 2018

fixed by #4076

@richvdh richvdh closed this as completed Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richvdh richvdh

Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics. z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilisfragile @richvdh @hawkowl