This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Change EventContext to use the Storage class #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
commented
Dec 18, 2019
| @@ -295,28 +298,30 @@ class _AsyncEventContextImpl(EventContext): | |||
| that was replaced. | |||
| """ | |||
|
|
|||
| # This needs to have a default as we're inheriting | |||
| _storage = attr.ib(default=None) | |||
There was a problem hiding this comment.
Annoyingly this needs a default, otherwise attr complains (as we're inheriting from a attr class which have attributes with default values). I'm not sure if there's another way round this beyond removing all the defaults.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'fa780e972': Change EventContext to use the Storage class (#6564)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as
get_state_ids_for_groupwill be moving out of the main data store.