Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

invites from unreachable hosts not deleteable #761

Closed
silvio opened this issue May 2, 2016 · 4 comments
Closed

invites from unreachable hosts not deleteable #761

silvio opened this issue May 2, 2016 · 4 comments
Labels
A-Stuck-Invite Incoming invitations that won't go away

Comments

@silvio
Copy link

silvio commented May 2, 2016

I rise this issue on github too, I don't have gain attention on my jira entry.
On this page I have described that a invitation could not deleted if the host is not reachable any more.

It would be nice to have the ability to delete invitations.
@Tokodomo Tokodomo mentioned this issue Feb 7, 2017
Closed
@devz3r0
Copy link

devz3r0 commented Apr 1, 2017

i have the same issue with emailadresses which didn't respond.

@richvdh
Copy link
Member

richvdh commented Apr 20, 2017

believe this was fixed by #691.

@richvdh richvdh closed this as completed Apr 20, 2017
This was referenced Apr 20, 2017
Closed
Closed
@grawity grawity mentioned this issue Apr 20, 2017
Closed
@richvdh
Copy link
Member

richvdh commented Apr 20, 2017

ohhkay. So, I'm not sure this was actually fixed for unreachable hosts. #691 only fixed it for hosts which are reachable, but return an error when you try to reject the invite. Furthermore, #991 appears to have regressed it for servers which return 500 errors too.

@richvdh richvdh reopened this Apr 20, 2017
@richvdh richvdh mentioned this issue Apr 20, 2017
Closed
richvdh added a commit that referenced this issue Apr 21, 2017
@richvdh
Broaden the conditions for locally_rejecting invites
838810b 
The logic for marking invites as locally rejected was all well and good, but
didn't happen when the remote server returned a 500, or wasn't reachable, or
had no DNS, or whatever.

Just expand the except clause to catch everything.

Fixes #761.
@richvdh richvdh mentioned this issue Apr 21, 2017
Merged
@richvdh
Copy link
Member

richvdh commented Apr 28, 2017

this was fixed by #2145

@richvdh richvdh closed this as completed Apr 28, 2017
@richvdh richvdh added the A-Stuck-Invite Incoming invitations that won't go away label May 3, 2017
@ghost ghost mentioned this issue May 17, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Stuck-Invite Incoming invitations that won't go away
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@silvio @richvdh @devz3r0