Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Bump regex from 1.7.3 to 1.8.1 #15472

Closed
wants to merge 2 commits into from
Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 24, 2023

Bumps regex from 1.7.3 to 1.8.1.

Changelog

Sourced from regex's changelog.

1.8.1 (2023-04-21)

This is a patch release that fixes a bug where a regex match could be reported where none was found. Specifically, the bug occurs when a pattern contains some literal prefixes that could be extracted and an optional word boundary in the prefix.

Bug fixes:

  • [BUG #981](rust-lang/regex#981): Fix a bug where a word boundary could interact with prefix literal optimizations and lead to a false positive match.

1.8.0 (2023-04-20)

This is a sizeable release that will be soon followed by another sizeable release. Both of them will combined close over 40 existing issues and PRs.

This first release, despite its size, essentially represent preparatory work for the second release, which will be even bigger. Namely, this release:

  • Increases the MSRV to Rust 1.60.0, which was released about 1 year ago.
  • Upgrades its dependency on aho-corasick to the recently release 1.0 version.
  • Upgrades its dependency on regex-syntax to the simultaneously released 0.7 version. The changes to regex-syntax principally revolve around a rewrite of its literal extraction code and a number of simplifications and optimizations to its high-level intermediate representation (HIR).

The second release, which will follow ~shortly after the release above, will contain a soup-to-nuts rewrite of every regex engine. This will be done by bringing regex-automata into this repository, and then changing the regex crate to be nothing but an API shim layer on top of regex-automata's API.

These tandem releases are the culmination of about 3 years of on-and-off work that began in earnest in March 2020.

Because of the scale of changes involved in these releases, I would love to hear about your experience. Especially if you notice undocumented changes in behavior or performance changes (positive or negative).

Most changes in the first release are listed below. For more details, please see the commit log, which reflects a linear and decently documented history of all changes.

New features:

... (truncated)

Commits
  • 4e29fce 1.8.1
  • 8a7cb64 deps: bump regex-syntax to 0.7.1
  • 31c8452 regex-syntax-0.7.1
  • 960aade changelog: 1.8.1
  • f003d72 impl: fix prefix literal matching bug
  • 93316a3 doc: update MSRV in README
  • 070374f release: 1.8.0
  • a73c61c fuzz: get rid of 'named-profiles' feature
  • 7cd75d2 changelog: tweaks to 1.8 release entry
  • 33898de syntax: fix bug in new alternation literal analysis
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [regex](https://github.com/rust-lang/regex) from 1.7.3 to 1.8.1.
- [Release notes](https://github.com/rust-lang/regex/releases)
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md)
- [Commits](rust-lang/regex@1.7.3...1.8.1)

---
updated-dependencies:
- dependency-name: regex
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner April 24, 2023 05:05
@dependabot dependabot bot added dependencies Pull requests from dependabot that update a dependency file rust Pull requests that update Rust code labels Apr 24, 2023
@DMRobertson
Copy link
Contributor

Increases the MSRV to Rust 1.60.0, which was released about 1 year ago.

This is currently incompatible with our MSRV (1.58). If we want to land this, we could bump the MSRV as per https://matrix-org.github.io/synapse/latest/deprecation_policy.html.

@erikjohnston
Copy link
Member

I'm personally in favour of not worrying too much about MSRV if we bump to a Rust version over a year old

@DMRobertson
Copy link
Contributor

The team has a slight desire to do land this so that we don't find ourselves suddenly with a need to deal with this problem in the future if there was an urgent fix to this library; though there isn't anything in particular from this update that we want per se.

@reivilibre reivilibre removed the request for review from a team May 5, 2023 14:55
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 29, 2023

A newer version of regex exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@clokep
Copy link
Contributor

clokep commented May 29, 2023

The team has a slight desire to do land this so that we don't find ourselves suddenly with a need to deal with this problem in the future if there was an urgent fix to this library; though there isn't anything in particular from this update that we want per se.

What's the next step here then? How do we make a decision?

@DMRobertson
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 12, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@DMRobertson
Copy link
Contributor

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 12, 2023

Superseded by #15769.

@dependabot dependabot bot closed this Jun 12, 2023
@dependabot dependabot bot deleted the dependabot/cargo/regex-1.8.1 branch June 12, 2023 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests from dependabot that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants