Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Convert simple_select_list_paginate_txn to return tuples. #16433

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Oct 5, 2023

More of my war on cursor_to_dict. Follow-u to #16431. This targets a single "simple" method: simple_select_list_paginate_txn and its two callers.

@clokep clokep marked this pull request as ready for review October 5, 2023 14:25
@clokep clokep requested a review from a team as a code owner October 5, 2023 14:25
@@ -395,7 +395,7 @@ class PresenceDestinationsRow(BaseFederationRow):
@staticmethod
def from_data(data: JsonDict) -> "PresenceDestinationsRow":
return PresenceDestinationsRow(
state=UserPresenceState.from_dict(data["state"]), destinations=data["dests"]
state=UserPresenceState(**data["state"]), destinations=data["dests"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really need to nuke this, but it seemed like a useless method?

@clokep clokep merged commit 06bbf10 into develop Oct 6, 2023
38 checks passed
@clokep clokep deleted the clokep/axe-cursor-to-dict-2 branch October 6, 2023 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants