This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add a Postgres REPLICA IDENTITY to tables that do not have an implicit one. This should allow use of Postgres logical replication.
#16456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/replica_identities
branch
6 times, most recently
from
ad592a0
to
417f5c0
Compare
reivilibre
force-pushed
the
rei/replica_identities
branch
from
417f5c0
to
6fcc720
Compare
clokep
reviewed
Oct 23, 2023
synapse/storage/schema/main/delta/82/04_replica_identities.sql.postgres
Outdated
Show resolved
Hide resolved
synapse/storage/schema/main/delta/82/04_replica_identities.sql.postgres
Outdated
Show resolved
Hide resolved
synapse/storage/schema/main/delta/82/04_replica_identities.sql.postgres
Outdated
Show resolved
Hide resolved
reivilibre
force-pushed
the
rei/replica_identities
branch
from
a1afdc2
to
89ebcd6
Compare
clokep
approved these changes
Nov 13, 2023
|
Although looks like your new test is failing? |
|
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
clokep
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Ah I think these will all go away in #16522, but no reason not to have it be correct for now.
There was a problem hiding this comment.
ohhhh that's why these were there a while ago, went away and now came back
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16224
Base:
developOriginal commit schedule, with full messages:
Add Postgres replica identities to tables that don't have an implicit one
Fixes All tables in Postgres should have a
REPLICA IDENTITYavailable so that Postgres logical replication can be used #16224