Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add fast path for replication events stream fetch #16580

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Oct 30, 2023

We can bail early if the from token is greater than or equal to the current token.

This can happen when the ID gen advances the current token for a remote writer past its last write.

Side note: I want to change how we do all this streaming stuff to put the ID generators in charge, which might be easier to grok rather than having abstract "streams" 🤷

Kinda follows on from #16473

We can bail early if the from token is greater than or equal to the
current token.
@erikjohnston erikjohnston marked this pull request as ready for review October 30, 2023 14:14
@erikjohnston erikjohnston requested a review from a team as a code owner October 30, 2023 14:14
@clokep clokep removed the request for review from a team October 30, 2023 14:28
@erikjohnston erikjohnston merged commit 408c138 into develop Oct 30, 2023
41 checks passed
@erikjohnston erikjohnston deleted the erikj/bail_early branch October 30, 2023 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants