This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make presence.get_new_events a bit faster #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this by caching the set of users a user shares rooms with.
| @@ -280,6 +280,23 @@ def get_rooms_for_user(self, user_id): | |||
| user_id, membership_list=[Membership.JOIN], | |||
| ) | |||
|
|
|||
| @cachedInlineCallbacks(max_entries=50000, cache_context=True, iterable=True) | |||
| def get_users_who_share_room_with_user(self, user_id, cache_context): | |||
There was a problem hiding this comment.
I guess we are leaking the cache_context.invalidate callbacks if this cache is smaller than the get_users_in_room or get_rooms_for_user caches. I wonder if we need a max_entries at all for dependant caches like this one since it can't be bigger than the get_rooms_for_user or get_users_in_room caches.
synapse/util/caches/descriptors.py
Outdated
| @@ -478,6 +478,8 @@ def update_results_dict(res): | |||
|
|
|||
|
|
|||
| class _CacheContext(namedtuple("_CacheContext", ("cache", "key"))): | |||
| # We rely on _CacheContext implementing __eq__ and __hash__ sensibly, | |||
| # which namedtuple does for us. | |||
There was a problem hiding this comment.
Maybe expound on the nature of the reliance?
There was a problem hiding this comment.
(I'm worried that future me will find this comment and will have forgotten what bit of code relies on these having __eq__ and __hash__ defined "sensibly" or what sensible means in this case)
|
Other than the sightly cryptic comment LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this by caching the set of users a user shares rooms with.