This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
make python 3 work in the docker container #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcgruenhage
force-pushed
the
jcgruenhage/docker-support-python3
branch
from
30488bd
to
3af7a95
Compare
richvdh
suggested changes
Sep 25, 2018
docker/Dockerfile
Outdated
| @@ -12,6 +13,7 @@ RUN apk add --no-cache --virtual .build_deps \ | |||
| postgresql-dev \ | |||
| zlib-dev \ | |||
| && cd /synapse \ | |||
| && sed -i 's/\["synctl"\] + //' setup.py \ | |||
There was a problem hiding this comment.
this should be redundant now due to #3948, and I'm a bit concerned it is rather fragile (we'll get a surprise down the line if we ever change that line in setup.py). Can we remove it?
(if you want to exclude synctl from the final image, do it in the rm below?)
|
I haven't tested this yet, with #3948 it should be good now |
richvdh
approved these changes
Sep 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.