This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Run our oldest supported configuration in CI #3952
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e116c86
update some of the deps. canonicaljson needs frozendict>=1. service_i…
hawkowl 1d06672
add an old config
hawkowl 1bb8dda
add it to travis
hawkowl d611863
fix
hawkowl 11c94bf
update tox file
hawkowl 902d038
Merge remote-tracking branch 'origin/develop' into hawkowl/oldest-in-ci
hawkowl 8634405
add more scripts
hawkowl 3edf852
update minimum tests
hawkowl 58a60a1
fix for travis
hawkowl 0d69bad
fix for travis
hawkowl 404996c
Merge remote-tracking branch 'origin/develop' into hawkowl/oldest-in-ci
hawkowl b889666
fix for travis
hawkowl a39a4dc
update
hawkowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Run the test suite on the oldest supported versions of our dependencies in CI. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,6 +64,26 @@ setenv = | |
{[base]setenv} | ||
SYNAPSE_POSTGRES = 1 | ||
|
||
# A test suite for the oldest supported versions of Python libraries, to catch | ||
# any uses of APIs not available in them. | ||
[testenv:py27-old] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you add a comment explaining what this env does (and why)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
skip_install=True | ||
deps = | ||
# Old automat version for Twisted | ||
Automat == 0.3.0 | ||
|
||
mock | ||
lxml | ||
commands = | ||
/usr/bin/find "{toxinidir}" -name '*.pyc' -delete | ||
# Make all greater-thans equals so we test the oldest version of our direct | ||
# dependencies, but make the pyopenssl 17.0, which can work against an | ||
# OpenSSL 1.1 compiled cryptography (as older ones don't compile on Travis). | ||
/bin/sh -c 'python -m synapse.python_dependencies | sed -e "s/>=/==/g" -e "s/psycopg2==2.6//" -e "s/pyopenssl==16.0.0/pyopenssl==17.0.0/" | xargs pip install' | ||
# Install Synapse itself. This won't update any libraries. | ||
pip install -e . | ||
{envbindir}/trial {env:TRIAL_FLAGS:} {posargs:tests} {env:TOXSUFFIX:} | ||
|
||
[testenv:py35] | ||
usedevelop=true | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't this need listing under
envlist
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The envlist is just what's run on
tox
with no args, so I guess not?