New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to prometheus_client<0.4 to avoid renaming all of our metrics #4002

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Oct 3, 2018

No description provided.

@richvdh

This comment has been minimized.

Member

richvdh commented Oct 3, 2018

(this fixes #4001 for now)

@richvdh

This comment has been minimized.

Member

richvdh commented Oct 3, 2018

(NB this is PRed against the release branch, as otherwise everyone who tries to upgrade is going to get bitten)

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 3, 2018

@richvdh richvdh merged commit e5f080d into release-v0.33.6 Oct 3, 2018

8 of 10 checks passed

ci/circleci: sytestpy2postgresmerged Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/pin_prometheus branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment