New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replication for room v3 #4523

Merged
merged 2 commits into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 30, 2019

We were not correctly quoting the path fragments over http replication,
which meant that it exploded when the event IDs had a slash in them

Fix replication for room v3
We were not correctly quoting the path fragments over http replication,
which meant that it exploded when the event IDs had a slash in them

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 30, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #4523 into develop will increase coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #4523      +/-   ##
===========================================
+ Coverage     74.7%   74.73%   +0.03%     
===========================================
  Files          337      337              
  Lines        34447    34447              
  Branches      5615     5615              
===========================================
+ Hits         25732    25744      +12     
+ Misses        7124     7112      -12     
  Partials      1591     1591
@richvdh
Copy link
Member

richvdh left a comment

lgtm

@hawkowl hawkowl merged commit a4f52a3 into develop Jan 30, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the erikj/fix_replication branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment