Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add some debug for membership syncing issues #4538

Merged
merged 1 commit into from
Jan 31, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/4538.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add some debug for membership syncing issues
13 changes: 11 additions & 2 deletions synapse/handlers/sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -895,14 +895,17 @@ def generate_sync_result(self, sync_config, since_token=None, full_state=False):
Returns:
Deferred(SyncResult)
"""
logger.info("Calculating sync response for %r", sync_config.user)

# NB: The now_token gets changed by some of the generate_sync_* methods,
# this is due to some of the underlying streams not supporting the ability
# to query up to a given point.
# Always use the `now_token` in `SyncResultBuilder`
now_token = yield self.event_sources.get_current_token()

logger.info(
"Calculating sync response for %r between %s and %s",
sync_config.user, since_token, now_token,
)

user_id = sync_config.user.to_string()
app_service = self.store.get_app_service_by_user_id(user_id)
if app_service:
Expand Down Expand Up @@ -1390,6 +1393,12 @@ def _get_rooms_changed(self, sync_result_builder, ignored_users):
room_entries = []
invited = []
for room_id, events in iteritems(mem_change_events_by_room_id):
logger.info(
"Membership changes in %s: [%s]",
room_id,
", ".join(("%s (%s)" % (e.event_id, e.membership) for e in events)),
)

non_joins = [e for e in events if e.membership != Membership.JOIN]
has_join = len(non_joins) != len(events)

Expand Down