Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time-based account expiration #5027

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@babolivier
Copy link
Member

commented Apr 8, 2019

No description provided.

@babolivier babolivier force-pushed the babolivier/account_expiration branch 2 times, most recently from a76118b to 65322bc Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #5027 into develop will decrease coverage by 1.81%.
The diff coverage is 90.9%.

@@             Coverage Diff             @@
##           develop    #5027      +/-   ##
===========================================
- Coverage    61.59%   59.77%   -1.82%     
===========================================
  Files          332      328       -4     
  Lines        34227    34114     -113     
  Branches      5643     5631      -12     
===========================================
- Hits         21082    20393     -689     
- Misses       11631    12218     +587     
+ Partials      1514     1503      -11

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 9, 2019

@babolivier

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

One thing I'm still not sure about wrt this PR is the unit of time for the validity period. I chose weeks, but it might make as much sense (or even more) to change that to days?

@erikjohnston
Copy link
Member

left a comment

Looks functionally good! Just a few nits

Show resolved Hide resolved docs/sample_config.yaml Outdated
Show resolved Hide resolved synapse/storage/registration.py Outdated
Show resolved Hide resolved synapse/storage/registration.py Outdated
Show resolved Hide resolved synapse/config/registration.py Outdated
Show resolved Hide resolved synapse/storage/registration.py Outdated
Show resolved Hide resolved synapse/storage/schema/delta/53/account_validity.sql Outdated

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 9, 2019

Show resolved Hide resolved synapse/storage/registration.py Outdated

@babolivier babolivier force-pushed the babolivier/account_expiration branch from f0fc335 to 747aa9f Apr 9, 2019

@babolivier babolivier merged commit bfc8fdf into develop Apr 9, 2019

22 checks passed

buildkite/synapse Build #911 passed (13 minutes, 12 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 12 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (55 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 12 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 58 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 39 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (11 minutes, 53 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (8 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (8 minutes, 3 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.