Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make all the rate limiting options more consistent #5181

Merged
merged 7 commits into from
May 15, 2019

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented May 13, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #5181 into develop will decrease coverage by <.01%.
The diff coverage is 92.3%.

@@             Coverage Diff             @@
##           develop    #5181      +/-   ##
===========================================
- Coverage    62.16%   62.15%   -0.01%     
===========================================
  Files          336      336              
  Lines        34683    34684       +1     
  Branches      5678     5681       +3     
===========================================
- Hits         21559    21558       -1     
- Misses       11590    11591       +1     
- Partials      1534     1535       +1

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

@hawkowl hawkowl merged commit f1e5b41 into develop May 15, 2019
@hawkowl hawkowl deleted the hawkowl/ratelimit-consistency branch May 15, 2019 17:06
richvdh added a commit that referenced this pull request Jul 4, 2019
- Put the default window_size back to 1000ms (broken by #5181)
- Make the `rc_federation` config actually do something
- fix an off-by-one error in the 'concurrent' limit
- Avoid creating an unused `_PerHostRatelimiter` object for every single
  incoming request
richvdh added a commit that referenced this pull request Jul 5, 2019
- Put the default window_size back to 1000ms (broken by #5181)
- Make the `rc_federation` config actually do something
- fix an off-by-one error in the 'concurrent' limit
- Avoid creating an unused `_PerHostRatelimiter` object for every single
  incoming request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants