Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add m.id_access_token flag #5930

Merged
merged 4 commits into from
Aug 30, 2019
Merged

Add m.id_access_token flag #5930

merged 4 commits into from
Aug 30, 2019

Conversation

anoadragon453
Copy link
Member

Adds a flag to /versions' unstable_features section indicating that this Synapse understands what an id_access_token is, as per #5927 (comment)

Fixes #5927

@anoadragon453 anoadragon453 requested a review from a team August 29, 2019 10:57
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that we do indeed support the features indicated by the flag, lgtm

@richvdh
Copy link
Member

richvdh commented Aug 30, 2019

(could you link to the PR(s) which added the relevant support, for future reference?)

@jryans
Copy link
Contributor

jryans commented Aug 30, 2019

(could you link to the PR(s) which added the relevant support, for future reference?)

For Riot Web at least, this was done in matrix-org/matrix-js-sdk#1022.
For Riot iOS, work is in progress under element-hq/element-ios#2603.
For Riot Android, work has not yet happened yet under element-hq/riot-android#3228.

@anoadragon453
Copy link
Member Author

@richvdh Assume you want to wait for this to merge before MSC'ing happens?

@anoadragon453
Copy link
Member Author

And speaking of which, the MSC has gone into FCP: matrix-org/matrix-spec-proposals#2264

@anoadragon453 anoadragon453 merged commit 4765f0c into develop Aug 30, 2019
@anoadragon453 anoadragon453 deleted the anoa/m_id_access_token branch August 30, 2019 14:22
@richvdh
Copy link
Member

richvdh commented Aug 30, 2019

(could you link to the PR(s) which added the relevant support, for future reference?)

For Riot Web at least, this was done in matrix-org/matrix-js-sdk#1022.
For Riot iOS, work is in progress under vector-im/riot-ios#2603.
For Riot Android, work has not yet happened yet under vector-im/riot-android#3228.

Thanks for this, but I was really looking for where the synapse support was added...

@anoadragon453
Copy link
Member Author

anoadragon453 commented Aug 30, 2019

Oh you mean where we accept the id_access_token parameter?

That is added as part of #5892

anoadragon453 added a commit that referenced this pull request Aug 30, 2019
anoadragon453 added a commit that referenced this pull request Aug 30, 2019
babolivier pushed a commit that referenced this pull request Sep 1, 2021
Adds a flag to `/versions`' `unstable_features` section indicating that this Synapse understands what an `id_access_token` is, as per #5927 (comment)

Fixes #5927
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-privacy-sprint (Deprecated Label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants