Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

add M_TOO_LARGE error code for uploading a too large file #6151

Merged
merged 7 commits into from
Oct 8, 2019
Merged

add M_TOO_LARGE error code for uploading a too large file #6151

merged 7 commits into from
Oct 8, 2019

Conversation

AnshulAngaria
Copy link
Contributor

Pull Request Checklist

Fixes #6109
Signed-off-by: Anshul Angaria angaria.anshul37@gmail.com

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@richvdh richvdh requested a review from a team October 3, 2019 11:34
anoadragon453
anoadragon453 previously requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some minor corrections below to appease the linters.

synapse/rest/media/v1/upload_resource.py Outdated Show resolved Hide resolved
changelog.d/6109.bugfix Outdated Show resolved Hide resolved
changelog.d/6109.bugfix Outdated Show resolved Hide resolved
AnshulAngaria and others added 2 commits October 8, 2019 10:09
@AnshulAngaria @anoadragon453
Update changelog.d/6109.bugfix
8498101 
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@AnshulAngaria @anoadragon453
Update synapse/rest/media/v1/upload_resource.py
ef74e87 
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
babolivier
babolivier previously requested changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great otherwise! Thanks for your contribution btw!

synapse/rest/media/v1/upload_resource.py Outdated Show resolved Hide resolved
@AnshulAngaria @babolivier
Update synapse/rest/media/v1/upload_resource.py
786de96 
Co-Authored-By: Brendan Abolivier <github@brendanabolivier.com>
@AnshulAngaria
Copy link
Contributor Author

Looking forward to contribute further!

@AnshulAngaria AnshulAngaria reopened this Oct 8, 2019
@babolivier babolivier dismissed stale reviews from anoadragon453 and themself October 8, 2019 11:19

stale

anoadragon453
anoadragon453 suggested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny little change, then I think it's good to go from me :)

changelog.d/6109.bugfix Outdated Show resolved Hide resolved
@AnshulAngaria @anoadragon453
Update changelog.d/6109.bugfix
6c53db4 
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
anoadragon453
anoadragon453 approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!

@anoadragon453 anoadragon453 merged commit 474abf1 into matrix-org:develop Oct 8, 2019
@anoadragon453 anoadragon453 mentioned this pull request Oct 8, 2019
Closed
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
add M_TOO_LARGE error code for uploading a too large file (#6151)
0e00cb3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@babolivier babolivier Awaiting requested review from babolivier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnshulAngaria @anoadragon453 @babolivier