Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set room version default to 5 #6220

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@neilisfragile
Copy link
Contributor

neilisfragile commented Oct 19, 2019

No description provided.

@neilisfragile neilisfragile requested a review from matrix-org/synapse-core Oct 19, 2019
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 19, 2019

(an accompanying MSC would be great. I wouldn't expect it to be controversial)

Copy link
Member

richvdh left a comment

yeah we decided that https://matrix.org/docs/spec/#complete-list-of-room-versions should dictate the default room version and require an MSC to change.

I still don't entirely agree with it, but we discussed it round in circles for days and we should follow the conclusions of the discussion.

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Nov 5, 2019

We the spec team formally declare that Room Version 5 shall henceforth be considered the default room version all server implementations shall use.

@neilisfragile neilisfragile requested a review from richvdh Nov 6, 2019
@neilisfragile neilisfragile dismissed richvdh’s stale review Nov 6, 2019

v5 now default in spec

@richvdh
richvdh approved these changes Nov 7, 2019
Copy link
Member

richvdh left a comment

lgtm

@babolivier babolivier merged commit a42567e into develop Nov 14, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4995 passed (21 minutes, 30 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 28 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 39 seconds)
Details
buildkite/synapse/isort Passed (40 seconds)
Details
buildkite/synapse/mypy Passed (25 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 28 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 45 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 34 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.