Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2326: Add background update to take previous events into account #6310

Merged
merged 21 commits into from Nov 7, 2019

Conversation

@babolivier
Copy link
Member

babolivier commented Oct 31, 2019

Built on top of #6301

Add a background update that goes through all of the events in the server's database and, for each event that has at least one label, saves those labels to the event_labels table, so that events sent prior to upgrading Synapse can be filtered by labels (like the ones sent after the upgrade).

Fixes #6288

@babolivier babolivier requested a review from matrix-org/synapse-core Oct 31, 2019
@richvdh richvdh self-assigned this Oct 31, 2019
@babolivier babolivier requested a review from matrix-org/synapse-core Nov 1, 2019
babolivier added 10 commits Oct 31, 2019
@babolivier babolivier force-pushed the babolivier/msc2326_bg_update branch from 573f782 to 3b29a73 Nov 4, 2019
babolivier added 4 commits Nov 4, 2019
@babolivier babolivier mentioned this pull request Nov 7, 2019
4 of 5 tasks complete
@babolivier babolivier requested a review from matrix-org/synapse-core Nov 7, 2019
@babolivier babolivier removed the request for review from matrix-org/synapse-core Nov 7, 2019
@babolivier babolivier requested a review from matrix-org/synapse-core Nov 7, 2019
babolivier added 2 commits Nov 7, 2019
@richvdh
richvdh approved these changes Nov 7, 2019
Copy link
Member

richvdh left a comment

lgtm other than these two nits

babolivier and others added 2 commits Nov 7, 2019
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@babolivier babolivier merged commit 46e5db9 into develop Nov 7, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5471 passed (20 minutes, 27 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 24 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 37 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (4 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 36 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 20 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 18 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 49 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 40 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 27 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.