Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove local threepids on account deactivation #6426

Merged
merged 6 commits into from
Nov 28, 2019
Merged

Remove local threepids on account deactivation #6426

merged 6 commits into from
Nov 28, 2019

Conversation

anoadragon453
Copy link
Member

Threepids bound to identity servers were being removed from a user's account on deactivation, but not local threepids. Probably best to clean these up.

@anoadragon453 anoadragon453 requested a review from a team November 27, 2019 15:46
@anoadragon453 anoadragon453 self-assigned this Nov 27, 2019
@erikjohnston
Copy link
Member

Don't we want to just delete the local threepids from the DB rather than trying to unbind them?

@erikjohnston
Copy link
Member

And does store.user_delete_threepid delete the right thing?

@anoadragon453
Copy link
Member Author

Don't we want to just delete the local threepids from the DB rather than trying to unbind them?

True, it is unnecessary/a privacy leak to ask IS' about it.

And does store.user_delete_threepid delete the right thing?

I believe so, though perhaps we should also remove any pending 3PID validation sessions so a threepid can't be added after deactivation occurs.

@erikjohnston
Copy link
Member

erikjohnston commented Nov 27, 2019 •
edited
Loading

And does store.user_delete_threepid delete the right thing?

I believe so, though perhaps we should also remove any pending 3PID validation sessions so a threepid can't be added after deactivation occurs.

Yeah, we want to 🔥🔥🔥 everything to do with the user

@anoadragon453
Copy link
Member Author

We should also remove any pending 3PID validation sessions so a threepid can't be added after deactivation occurs.

This looks more involved, so I'll do it in a separate PR.

erikjohnston
erikjohnston approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression test 😇

@anoadragon453 anoadragon453 mentioned this pull request Nov 27, 2019
Merged
@anoadragon453 anoadragon453 merged commit a9c44d4 into develop Nov 28, 2019
@anoadragon453 anoadragon453 deleted the anoa/deactivated_accounts_fix branch November 28, 2019 10:40
anoadragon453 added a commit that referenced this pull request Nov 28, 2019
@anoadragon453
Remove local threepids on account deactivation (#6426)
2030193
@richvdh richvdh mentioned this pull request Jan 9, 2020
Closed
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Remove local threepids on account deactivation (#6426)
8b47cb8 
* commit 'a9c44d400':
  Remove local threepids on account deactivation (#6426)
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Remove local threepids on account deactivation (#6426)
ebdeffc 
* commit '2030193e5':
  Remove local threepids on account deactivation (#6426)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @erikjohnston