-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clearer warning when failing to resolve seedNodes via DNS #752
Comments
@aryanjassal when you feel more comfortable with the source code this might be a good issue to start with. |
I want to clarify the requirements of this issue. For the first task, I need to include additional details, like a custom error message stating that DNS resolution failed, correct? For the second task, success of this function would happen just before the return statement in the function, right? If that is the case, then I just have to send a message stating that node resolution using DNS succeeded, right? I'm also not sure how to approach the task of using |
Don't get too stuck into this if you're struggling. The main goal is to get a top level overview of |
Related to #729? |
Yeah, this is related but on top of the warning this issue wants to add using the NodeGraph as a fallback for entering the network f we fail to resolve the seed nodes. |
Specification
During testing we found the warning
WARN:polykey:No seednodes could be found for for mainnet.polykey.com
This comes fromresolveSeednodes
src/nodes/utils.ts:427
.This was a result of the
tailscale
magic DNS acting up and preventing the ability to resolve the seed node addresses via DNS. As far as the behaviour goes, this is working as intended. However the messaging can be improved.We need to be clearer with the following details
seedNodes
error will cause thesyncNodeGraph
logic to skip entirely. So we wont get any warnings about a failure at that stage.NodeGraph
. These will trigger in the background.We can also look into actively using the
nodeGraph
as a fallback for entering the network. We can use either the closest nodes to us as the starting set, Nodes we've succeeded via direct connections in the past. Or keep better track of seed nodes in the graph and use them. Needs some discussion.Tasks
nodeGraph
entries as a fallback seednode list if resolving fails.The text was updated successfully, but these errors were encountered: