Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Not and Like expression, Fix char(0) bug #1432

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

m-schen
Copy link
Contributor

@m-schen m-schen commented Dec 17, 2021

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #850 #1129 #1138 #1192

What this PR does / why we need it:

  1. fix not operator not effective problem
  2. fix like operator not effective for select problem
  3. fix a char(0) length bug
  4. add uts for them

Special notes for your reviewer:

Not Available

Additional documentation (e.g. design docs, usage docs, etc.):

Not Available

@m-schen m-schen changed the title Fix Not and Like expression Fix Not and Like expression, Fix char(0) bug Dec 17, 2021
Copy link
Contributor

@nnsgmsone nnsgmsone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yingfeng yingfeng merged commit 5f4aea5 into matrixorigin:main Dec 20, 2021
@m-schen m-schen deleted the fix-main-not-like branch December 22, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants