Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Robust object positioning #3

Closed
matrx-software opened this issue Feb 27, 2020 · 4 comments
Closed

[CLOSED] Robust object positioning #3

matrx-software opened this issue Feb 27, 2020 · 4 comments

Comments

@matrx-software
Copy link
Collaborator

Issue by matrxs
Tuesday Jan 14, 2020 at 08:05 GMT
Originally opened as matrxs/MATRXS#2


Right now in the new frontend the grid is a set of aligned divs, which get their relative position from the div html position. However, in MATRXS multiple objects can occupy 1 cell in MATRXS. How can this be achieved in the new frontend?

This issue is related to when the objects are going to move. In that case, a more robust / free-floating positioning of objects seems to be required. E.g. absolute positioning?

@matrx-software
Copy link
Collaborator Author

Comment by wiardjorritsma
Wednesday Jan 15, 2020 at 10:29 GMT


I made a new version of init_grid to address this issue. Please check if this is a good solution. Then I'll fix the new layout issues it has created :)

@matrx-software
Copy link
Collaborator Author

Comment by matrxs
Thursday Jan 16, 2020 at 07:38 GMT


Looks good!

Only points which might become an issue is that all sizes and such are defined using the em css unit, as such:

    left: 40em;
    top: 20em;
    height: 5em;
    width: 5em;

According to here, em is defined as Relative to the font-size of the element (2em means 2 times the size of the current font). I think this becomes an issue when we wan't to have text of varying sizes in various objects, which also affects their height / width. So we might want to look into other units, such as px or vh.

Other issue is that it is not responsive yet, but that might fall under the new layout issues which you mentioned :) I would also think making the grid screen filling, while keeping the aspect ratio, would be best. However, if that is difficult with css we might also be able to do it with JS.

@matrx-software
Copy link
Collaborator Author

Comment by jwaa
Sunday Jan 26, 2020 at 20:05 GMT


@wiardjorritsma can this issue be closed? As it has been reviewed and approved, and no branch or merge request is linked to this.

@matrx-software
Copy link
Collaborator Author

Comment by wiardjorritsma
Tuesday Jan 28, 2020 at 15:43 GMT


Yes it can be closed

@thaije thaije closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant