Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust object positioning #2

Closed
matrxs opened this issue Jan 14, 2020 · 4 comments
Closed

Robust object positioning #2

matrxs opened this issue Jan 14, 2020 · 4 comments
Assignees

Comments

@matrxs
Copy link
Owner

matrxs commented Jan 14, 2020

Right now in the new frontend the grid is a set of aligned divs, which get their relative position from the div html position. However, in MATRXS multiple objects can occupy 1 cell in MATRXS. How can this be achieved in the new frontend?

This issue is related to when the objects are going to move. In that case, a more robust / free-floating positioning of objects seems to be required. E.g. absolute positioning?

@matrxs matrxs added the bug Work on something that isn't working label Jan 14, 2020
@matrxs matrxs added HTML-visualizer and removed bug Work on something that isn't working labels Jan 14, 2020
@wiardjorritsma
Copy link
Collaborator

I made a new version of init_grid to address this issue. Please check if this is a good solution. Then I'll fix the new layout issues it has created :)

@matrxs
Copy link
Owner Author

matrxs commented Jan 16, 2020

Looks good!

Only points which might become an issue is that all sizes and such are defined using the em css unit, as such:

    left: 40em;
    top: 20em;
    height: 5em;
    width: 5em;

According to here, em is defined as Relative to the font-size of the element (2em means 2 times the size of the current font). I think this becomes an issue when we wan't to have text of varying sizes in various objects, which also affects their height / width. So we might want to look into other units, such as px or vh.

Other issue is that it is not responsive yet, but that might fall under the new layout issues which you mentioned :) I would also think making the grid screen filling, while keeping the aspect ratio, would be best. However, if that is difficult with css we might also be able to do it with JS.

@jwaa
Copy link
Collaborator

jwaa commented Jan 26, 2020

@wiardjorritsma can this issue be closed? As it has been reviewed and approved, and no branch or merge request is linked to this.

@wiardjorritsma
Copy link
Collaborator

Yes it can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants