Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mutexes inside mock struct #128

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Move mutexes inside mock struct #128

merged 1 commit into from
Aug 16, 2020

Conversation

sudo-suhas
Copy link
Collaborator

Better to not be constrained by global locks when having multiple moq
instances.

Closes #71,
Replaces and closes #88.

@sudo-suhas
Copy link
Collaborator Author

@matryer can you please help here? The travis integration is broken. The build succeeded but it isn't reflecting here - https://travis-ci.org/github/matryer/moq/builds/712833875. Could have something to do with travis-ci/travis-ci#9440 (comment).

@sudo-suhas
Copy link
Collaborator Author

Tried switching to GitHub Actions in #129 but that didn't work as expected. And cannot disable the Travis CI check even if I remove .travis.yml 😞 .

@matryer
Copy link
Owner

matryer commented Aug 15, 2020

@sudo-suhas Sorry I missed this. I have relaxed the rules so you should be able to proceed without that check. But Travis wasn't letting me sign in today, for some reason. Also, the tests fail when I run them, so I'm not 100% sure they'll run on Travis either. I simplified the travis config while I was playing around, happy to keep that or put it back, whatever makes sense.

@sudo-suhas
Copy link
Collaborator Author

Also, the tests fail when I run them, so I'm not 100% sure they'll run on Travis either.

I think the problem is the changes introduced in f76652f. Although the build status was not reported back here, the build itself was passing on travis - https://travis-ci.org/github/matryer/moq/builds/712833875.

@sudo-suhas
Copy link
Collaborator Author

sudo-suhas commented Aug 16, 2020

Resolved the Go modules and CI related issues via #135.

Better to not be constrained by global locks when having multiple moq
instances.

Co-authored-by: Diego Bernardes <diego.bernardes@outlook.com>
@sudo-suhas sudo-suhas merged commit c5b1da6 into master Aug 16, 2020
@sudo-suhas sudo-suhas deleted the no-global-mutex branch August 16, 2020 06:33
sudo-suhas added a commit that referenced this pull request Aug 16, 2020
Minor changes to generated test file because of c5b1da6 (#128).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why the global mutexes on mocks?
2 participants