Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal binaries for macOS #159

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Universal binaries for macOS #159

merged 1 commit into from
Nov 14, 2021

Conversation

sudo-suhas
Copy link
Collaborator

A special format that contains both arm64 and amd64 executables in a single file.

A special format that contains both arm64 and amd64 executables in a single file
@sudo-suhas
Copy link
Collaborator Author

@sudo-suhas
Copy link
Collaborator Author

@matryer @breml please share your feedback if you have any. Will merge this change in in a few days if there are no concerns raised.

@breml
Copy link
Contributor

breml commented Nov 13, 2021

@sudo-suhas I am not a mac user, so I can not test this, sorry. But as far as I can tell, the PR looks good to me.

@sudo-suhas
Copy link
Collaborator Author

Thanks @breml. There is one aspect that I would appreciate feedback on. Fat binaries, as the name suggests, are large in size since they contain binaries targeting both architectures. Currently, I am opting to publish fat as well as architecture-specific binaries so that if someone wishes to download the more specific smaller size binary, they can. Would you agree with this choice?

@breml
Copy link
Contributor

breml commented Nov 13, 2021

Yes, this sounds good to me.

@sudo-suhas sudo-suhas merged commit ef8b268 into master Nov 14, 2021
@sudo-suhas sudo-suhas deleted the mac-universal-binaries branch November 14, 2021 11:09
@sudo-suhas
Copy link
Collaborator Author

Changes released in v0.2.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants