Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateJsonEditor should ignore package.json #150

Closed
shiena opened this issue Aug 11, 2021 · 7 comments
Closed

StateJsonEditor should ignore package.json #150

shiena opened this issue Aug 11, 2021 · 7 comments

Comments

@shiena
Copy link

shiena commented Aug 11, 2021

StateJsonEditor should ignore package.json because upm's package.json is displayed by a dedicated Inspector.
This can be avoided by ae28b2e in #142.

View the inspector of package.json before unidux installation
image

View the inspector of package.json after unidux installation
image

@mattak
Copy link
Owner

mattak commented Aug 12, 2021

@shiena
Thanks for your mentions!
I created this editor extension for editing state json.
State json can be saved and loaded on the UniduxPanel.
(e.g. save count data on the scene and edit and load the data)

I think black listing style will be cost (excluding specific file, such as package.json)
UnityEngine and the other assets may control other filename json in future.

So I think white listing style would be better.
For example, using filename suffix such as .state.json or .unidux.json.
or remove this feature completely and export to the other assets might be good.

How do you think about this idea?

@shiena
Copy link
Author

shiena commented Aug 12, 2021

@mattak
I think the filename suffix idea is certainly better than the exclusion rule.
For those two, I would prefer the more unique .unidux.json.

@mattak
Copy link
Owner

mattak commented Aug 12, 2021

Thanks! I'll change it as soon as possible.

mattak added a commit that referenced this issue Aug 12, 2021
StateJsonEditor should ignore package.json #150
@mattak
Copy link
Owner

mattak commented Aug 12, 2021

@shiena

I created new release 0.4.1 for fixing package.json bug!

Current Inspector of package.json

@mattak mattak closed this as completed Aug 12, 2021
@shiena
Copy link
Author

shiena commented Aug 12, 2021

@mattak
Now that upm is supported, I've registered for openupm.
https://openupm.com/packages/me.mattak.unidux/

openupm requires the same git tag as the version in package.json.
Therefore, it would be very useful if you could update the version of package.json to 0.4.1 and re-tag it with the git tag.

@mattak
Copy link
Owner

mattak commented Aug 13, 2021

@shiena Thanks! I forgot to update UPM version.
To avoid the issue, I've created release script.
https://github.com/mattak/Unidux/blob/master/script/release.sh

I think pushed git tag should not be overwritten.
So I rolled out next version 0.4.2 and fit UPM version and git tag version.
I'm not permitted to operate openupm, so please apply the settings to detect new version tag.

@shiena
Copy link
Author

shiena commented Aug 13, 2021

@mattak Thanks you.
The version of package.json and the git tag have been matched, so it will be automatically applied to openupm.
https://openupm.com/packages/me.mattak.unidux/?subPage=pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants