Add constructor to SubredditPaginator with parameter for subreddit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your commit. The Travis build failed, but I don't think that's because of your changes. I'll run the tests again once I can get my laptop working properly. |
|
It appears to be due security restrictions that Travis imposes on secure environment variables when handling pull requests from a forked repo. Not sure the best way to handle this scenario - this is the first time I've worked with Travis. I'll read into it. Matt |
|
It worked on my Raspberry Pi, so I'll go ahead and merge it. I'll have to change the unit tests/gradle config so that tests that require a username/password aren't run for pull request builds. |
mattbdean
added a commit
that referenced
this pull request
Sep 10, 2014
Add constructor to SubredditPaginator with parameter for subreddit
fbis251
pushed a commit
to fbis251/JRAW
that referenced
this pull request
Apr 28, 2016
Facilitate using jitpack
dukestreet
pushed a commit
to dukestreet/JRAW
that referenced
this pull request
Feb 13, 2022
* Submission: is_gallery field * Submission: gallery_data field * GalleryData adapter * Submission: media_metadata field * Enable moshi kapt codegen * Add original to MediaMetadata * Revert "GalleryData adapter" This reverts commit df64b2c. * Use generated adapter for GalleryData * Add caption field for gallery * Support for gifs in media_metadata * media_metadata: some fields are optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New constructor in SubredditPaginator to simplify paging over a subreddit.
Change the way we pull username/pass in unit tests to split correctly on Windows too.