Remove recommendation for Capybara disable_animation
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capybara's `disable_animation` option inserts a middleware that can conflict with other middleware, like `Rack::Deflater`. If removing animation is important for speeding up system tests, a more direct way to do it is to conditionally add CSS/JS to the application layout, rather rely on a middleware that could have unexpected side effects. Given the potential complications, I am removing `disable_animation` from the default Capybara config file that nextgen generates.
mattbrictson
added
✨ Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capybara's
disable_animationoption inserts a middleware that can conflict with other middleware, likeRack::Deflater. If removing animation is important for speeding up system tests, a more direct way to do it is to conditionally add CSS/JS to the application layout, rather rely on a middleware that could have unexpected side effects.Given the potential complications, I am removing
disable_animationfrom the default Capybara config file that nextgen generates.