Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using event.code instead of event.key locks out disabled users #19

Closed
elfsternberg opened this issue Dec 4, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@elfsternberg
Copy link

Using event.code means that people with non-standard keyboards such as Dvorak, Coleman, or any number of specialty keyboards meant to be used by those with amputations or palsy don't have the keys where their assistive devices expect, preventing them from using the extension.

I'd have a PR for this, but I'm at work when I noticed it. Maybe when I get home, and figure out how to load an extension from build. (Haven't worked on extensions before; mostly just used Tampermonkey.)

@mattburesh
Copy link
Owner

mattburesh commented Dec 5, 2024

Thanks for bringing this up @elfsternberg! I didn't know that about event.code. If you're able to put something together that'd be awesome, otherwise I can probably get to it tomorrow or this weekend.

Edit: Oh, and let me know if run into any issues building the extension. The instructions make sense to me, but I haven't had anyone else try it yet.

@mattburesh
Copy link
Owner

This should be fixed in the latest release (v1.0.6). The Firefox add-on is up to date, but it will take a couple days for the chrome web store to approve the latest version.

I'm going to close this, but if you notice it still isn't working right go ahead and reopen it.

@elfsternberg
Copy link
Author

Thank you! (I was just about to send a PR, but... whatever. As long as it helps.) And looking at the PR, yeah, that's exactly the same change I was gonna make:

const key = event.key.length === 1 ? event.key.toLowerCase() : event.key;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants