Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for blob based pubdata #138

Merged
merged 75 commits into from
Feb 21, 2024
Merged

Adding support for blob based pubdata #138

merged 75 commits into from
Feb 21, 2024

Conversation

koloz193
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

StanislavBreadless
StanislavBreadless reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I know it is a draft, but I still left some nits so we don't forget about those

l1-contracts/contracts/zksync/facets/Executor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/Storage.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/facets/Executor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/facets/Executor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/facets/Executor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/interfaces/IExecutor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/interfaces/IExecutor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/interfaces/IExecutor.sol Outdated Show resolved Hide resolved
system-contracts/contracts/Constants.sol Outdated Show resolved Hide resolved
system-contracts/contracts/L1Messenger.sol Outdated Show resolved Hide resolved
mm-zk
mm-zk previously requested changes Jan 8, 2024
View reviewed changes
system-contracts/contracts/PubdataChunkPublisher.sol Outdated Show resolved Hide resolved
system-contracts/contracts/PubdataChunkPublisher.sol Outdated Show resolved Hide resolved
system-contracts/contracts/PubdataChunkPublisher.sol Outdated Show resolved Hide resolved
system-contracts/contracts/Constants.sol Show resolved Hide resolved
system-contracts/contracts/Constants.sol Show resolved Hide resolved
l1-contracts/contracts/zksync/interfaces/IExecutor.sol Outdated Show resolved Hide resolved
l1-contracts/test/foundry/unit/concrete/Executor/Authorization.t.sol Show resolved Hide resolved
l1-contracts/contracts/zksync/facets/Executor.sol Outdated Show resolved Hide resolved
l1-contracts/contracts/zksync/facets/Executor.sol Show resolved Hide resolved
l1-contracts/contracts/zksync/facets/Executor.sol Outdated Show resolved Hide resolved
@koloz193
Adding 4844 Based Tests (#169)
abcbaf3
@koloz193
chore(docstrings): added doc string comments where missing (#189)
05dc432
@koloz193
feat(tests): added tests for pubdata chunk publisher (#188)
049c47a
@koloz193
fix(L1Messenger): validate pubdata before publishing blob hashes (#187)
e89c21c
@koloz193
fix(commitBatches): removed unnecessary require (#186)
ced1fca
@koloz193
chore(contracts): fixed spelling (#185)
d90e27d
@koloz193
chore(L2ContractAddresses): updated ordering of contract address to b…
f8be09f 
…e sorted asc (#184)
@koloz193
fix(Executor): combined var declaration and assignment (#183)
6c0ac0e
@koloz193
chore(IPubdataChunkPublisher): added natspec comment with security co… (
d6d7f81 
#182)
@koloz193
chore(contracts): removed todo comments (#181)
7560746
@koloz193
fix(bootloader): updated comment to reflect new value (#180)
91b48f9
@koloz193
fix(executor): separated require with 2 conditions into 2 statements (#…
bd09d4f 
…179)
@koloz193
fix(bootloader): fixed system log key for protocol upgrade txn hash (#…
d95f4f9 
…178)
@koloz193
bump system contracts hashes
e7775aa
@koloz193
Merge branch 'dev' into zk-4844
c631705
@koloz193
moved blob versioned hash getter to storage (#197)
ac3bdb6
@koloz193
added dev tag to comment
c4d3e49
@StanislavBreadless @koloz193
Increase the area dedicated to pubdata encoding (#207)
5c45359 
Co-authored-by: koloz <zach.kolodny@gmail.com>
@koloz193 koloz193 merged commit abfad6f into dev Feb 21, 2024
17 checks passed
@koloz193 koloz193 deleted the zk-4844 branch February 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamatar shamatar shamatar left review comments

@mm-zk mm-zk Awaiting requested review from mm-zk

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless is a code owner

@vladbochok vladbochok Awaiting requested review from vladbochok vladbochok is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koloz193 @shamatar @vladbochok @StanislavBreadless @mm-zk