L1Messenger Tests #150
Merged
L1Messenger Tests #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neotheprogramist
requested review from
vladbochok and
StanislavBreadless
as code owners
Uacias
force-pushed
the
2-l1Messenger-tests
branch
from
0278380
to
e33d00b
Compare
Uacias
force-pushed
the
2-l1Messenger-tests
branch
from
0f88441
to
6703d6a
Compare
There was a problem hiding this comment.
Thank you for adding additional tests for this function. I think there are lot of places where code repetition could be reduced:
- In lots of places a large
const totalL2ToL1PubdataAndStateDiffs = ethers.utils.concatis done, with almost the same values everywhere. - Also,
const numberOfLogsBytes = ethers.utils.hexZeroPad(ethers.utils.hexlify(numberOfLogs), 4);this part is often repeated.
It is better to move all these methods to a separate functions, where we modify only things that really change between various tests
StanislavBreadless
approved these changes
Jan 23, 2024
AntonD3
approved these changes
Jan 23, 2024
matzayonc
pushed a commit
to neotheprogramist/era-contracts
that referenced
this pull request
Mar 1, 2024
Co-authored-by: Uacias <filgum0326@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.