Ivan/fix l1 l2 address conversion #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let x = ethers.BigNumber.from(address).add(L1_TO_L2_ALIAS_OFFSET) .mod(ADDRESS_MODULO). So x is a big number and applying to hexlify will convert it hex string without extra padding. E.g. if x == 1, then hexlify(x) == "0x1", we want address so it should padded to len 40.
ischasny
requested review from
vladbochok and
StanislavBreadless
as code owners
perekopskiy
previously approved these changes
Mar 11, 2024
perekopskiy
approved these changes
Mar 11, 2024
vladbochok
approved these changes
Mar 11, 2024
matzayonc
pushed a commit
to neotheprogramist/era-contracts
that referenced
this pull request
Mar 27, 2024
matzayonc
pushed a commit
to neotheprogramist/era-contracts
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let x = ethers.BigNumber.from(address).add(L1_TO_L2_ALIAS_OFFSET) .mod(ADDRESS_MODULO). So x is a big number and applying tohexlifywill convert it hex string without extra padding. E.g. ifx == 1, thenhexlify(x) == "0x1", we want address so it should padded to len 40.