-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix zkforge script support #211
Conversation
adfe1cf
to
8e6c0a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karrq I think some of the left over work / debugging is still present and needs to be updated to make use of the changes in main
. Particularly around zk_compile, and build.rs.
6055ee2
to
c9ef504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dutterbutter I updated the PR based on your comments and replied wrt the async zksolc setup
@dutterbutter I think we should look into merging this PR first, since the scripting itself is working. /cc @HermanObst |
@Karrq I think merging this in is fine and proceeding with fixing to include deployment scripts as discussed. Please address the comment regarding the default values. |
What π»
zkforge script
for files inscript/
dirWhy β
Evidence π·
The current evidence for these changes include the following steps:
make build-zkforge
cd min-example-zkfoundry
zkforge install
to download the various depsCounterScript
with:MyScript
with:Notes π
This branch is currently failing for any script that's using a cheatcode, e.g.CounterScript
. I've left comments in the branch with where we probably need to update the use ofexecutor.deploy
to run an era call/transaction (it's a call for this case aszkforge script
is not committing the call