Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log matching #237

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: Log matching #237

merged 2 commits into from
Jan 23, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Jan 23, 2024

What 💻

Why

  • In the past implementation if a given log A was expected but was not the first one found in the actual logs it would fail. This is not how the documentation presents the use case. It should need the right order of expected logs but there could be new ones after, before or in the middle of that expected logs.

@Jrigada Jrigada merged commit fec8c36 into main Jan 23, 2024
11 checks passed
@Jrigada Jrigada deleted the fix-jr-comparing-logs branch January 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants