Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Validium): add validium support for external node #1235

Conversation

lferrigno
Copy link
Contributor

@lferrigno lferrigno commented Feb 23, 2024

What

This pull request addresses the need to dynamically set the L1CommitGeneratorMode of the external node based on the configuration value l1_batch_commit_data_generator_mode in the etc/env/ext-node.toml file. If the configuration value is set, the external node will be configured for Validium; otherwise, the default mode will be Rollup.
Changes Made
Added logic to check for the presence of l1_batch_commit_data_generator_mode in etc/env/ext-node.toml.
If the value is set, the L1CommitGeneratorMode of the external node is set to "validium."
If the value is not set, the default mode "rollup" is used.
Users can manually update the configuration by adding l1_batch_commit_data_generator_mode="Validium" to the ext-node.toml file.

Why ❔

Need to add Valiidium support to EN

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@lferrigno lferrigno changed the title feat: add validium support external node feat(Validium): add validium support external node Feb 23, 2024
@mationorato mationorato changed the title feat(Validium): add validium support external node feat(Validium): add validium support for external node Feb 23, 2024
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Although later we'll probably would want to add a circuit breaker check described here to EN too, but this is certainly out of scope for this PR.

@mationorato
Copy link
Contributor

Hey @popzxc , thanks for the review.

Do you think we should add a special test case for this?

@popzxc
Copy link
Member

popzxc commented Feb 27, 2024

@mationorato I think it's fine to merge as-is.

@ilitteri ilitteri merged commit 6310305 into matter-labs:feat_validium_pubdata_abstraction Feb 28, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants