feat(Validium): adapt protobuf_config tests for running both in Validium mode and Rollup mode
#1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
reviewed
Feb 28, 2024
| @@ -498,7 +496,6 @@ impl RandomConfig for configs::eth_sender::GasAdjusterConfig { | |||
| internal_enforced_l1_gas_price: g.gen(), | |||
| poll_period: g.gen(), | |||
| max_l1_gas_price: g.gen(), | |||
| // TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this. | |||
There was a problem hiding this comment.
This TODO was removed because this field will be later removed in #1238
popzxc
approved these changes
Feb 29, 2024
…-labs/zksync-era into adapt-protobuf_config-tests
…zksync-era into adapt-protobuf_config-tests
ilitteri
merged commit e5d19ec
into
matter-labs:feat_validium_pubdata_abstraction
28 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adapt
protobuf_configto take into account the mode you are running, Validium or Rollup, usingL1BatchCommitDataGeneratorMode.Why ❔
These changes are made in order to use the
L1BatchCommitDataGeneratorMode(Rollup or Validium) in the implementation of theProtoReprtrait forStateKeeper, in charge of converting it into aStateKeeperConfig.Checklist
read()andbuild()ofprotobuf_configfor running both in Validium mode and Rollup mode.testonly.rsto fieldl1_batch_commit_data_generator_modewith a random value ofL1BatchCommitDataGeneratorModeforStateKeeperConfig.Testing
zk test rust --package zksync_protobuf_config --lib -j 1 -- tests