Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kl-factory): update contracts submodule #1591

Merged
merged 4 commits into from
Apr 5, 2024
Merged

fix(kl-factory): update contracts submodule #1591

merged 4 commits into from
Apr 5, 2024

Conversation

juan518munoz
Copy link
Contributor

@juan518munoz juan518munoz commented Apr 5, 2024 •
edited
Loading

What ❔

Update branch to latest commit of contracts submodule.

This PR also fixes some issues regarding zk test i server:

  • ETH deposit failing due to not being waited properly.
  • Base token not being distributed across accounts.

Why ❔

Fixes zk init --base-token-name BAT

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Code has been formatted via zk fmt and zk lint.

@juan518munoz juan518munoz changed the title Fix(kl-factory): update contracts submodule fix(kl-factory): update contracts submodule Apr 5, 2024
@lferrigno lferrigno requested a review from kelemeno April 5, 2024 18:48
@kelemeno kelemeno merged commit ee214a7 into matter-labs:kl-factory Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelemeno kelemeno Awaiting requested review from kelemeno

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juan518munoz @kelemeno