Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kl-factory): first init failing #1620

Merged

Conversation

SantiagoPittella
Copy link

What ❔

Alter the order of the commands in the init script.

Why ❔

The first init ran in the repo was failing because the contracts were being compiled before downloading the dependencies.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@SantiagoPittella
Copy link
Author

@kelemeno can you take a look a this please? When you do a fresh clone of the repo the first init is failing because of the order of the steps.

@kelemeno kelemeno merged commit 0fee8ca into matter-labs:kl-factory Apr 10, 2024
3 checks passed
@juan518munoz juan518munoz deleted the kl-factory-fix-first-init branch April 19, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants