Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move string constants to an additional file #2083

Merged
merged 26 commits into from
May 30, 2024

Conversation

matias-gonz
Copy link
Collaborator

@matias-gonz matias-gonz commented May 29, 2024

What ❔

Move string constants to an additional file

Why ❔

Easily change messages for the toolbox and allow translations in the future.

@matias-gonz matias-gonz changed the title Move string constants to an additional file chore: Move string constants to an additional file May 29, 2024
@matias-gonz matias-gonz marked this pull request as ready for review May 30, 2024 10:07
Copy link
Contributor

@Deniallugo Deniallugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hope it's the last one

Deniallugo
Deniallugo previously approved these changes May 30, 2024
@matias-gonz matias-gonz removed the request for review from aon May 30, 2024 14:07
Deniallugo
Deniallugo previously approved these changes May 30, 2024
Copy link
Contributor

@Deniallugo Deniallugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All great, but please let's wait for

#2100

and run zk fmt

@Deniallugo Deniallugo added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit ac0bef6 May 30, 2024
19 checks passed
@Deniallugo Deniallugo deleted the zk-inception-move-constants branch May 30, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants