feat(api): Do not return receipt if tx was not included to the batch #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-do-not-return-receipt-if-tx-was-not-included
branch
from
19d0bd1
to
ea74ac8
Compare
perekopskiy
previously approved these changes
Dec 18, 2023
Signed-off-by: Danil <deniallugo@gmail.com>
perekopskiy
reviewed
Dec 18, 2023
RomanBrodetski
previously approved these changes
Dec 19, 2023
perekopskiy
previously approved these changes
Dec 19, 2023
Deniallugo
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
RomanBrodetski
previously approved these changes
Dec 19, 2023
RomanBrodetski
approved these changes
Dec 19, 2023
RomanBrodetski
deleted the
deniallugo-do-not-return-receipt-if-tx-was-not-included
branch
This was referenced Dec 19, 2023
RomanBrodetski
pushed a commit
that referenced
this pull request
Dec 19, 2023
🤖 I have created a release *beep* *boop* --- ## [18.9.0](core-v18.8.0...core-v18.9.0) (2023-12-19) ### Features * Add ecadd and ecmul to the list of precompiles upon genesis ([#669](#669)) ([0be35b8](0be35b8)) * **api:** Do not return receipt if tx was not included to the batch ([#706](#706)) ([625d632](625d632)) * proto serialization/deserialization of snapshots creator objects ([#667](#667)) ([9f096a4](9f096a4)) * zk fmt sqlx-queries ([#533](#533)) ([6982343](6982343)) ### Bug Fixes * **en:** Downgrade miniblock hash equality assertion to warning ([#695](#695)) ([2ef3ec8](2ef3ec8)) ### Performance Improvements * remove unnecessary to_vec ([#702](#702)) ([c55a658](c55a658)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
For compatibility with Ethereum, we have to return
Receiptonly if tx is included in the miniblock. Block hash is not null null.Why ❔
For compatibility with Ethereum and for not breaking external clients, such as Metemask, they do not expect that block hash could be null
Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.