Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Add configuration APIs to era-test-node documentation #652

Conversation

MexicanAce
Copy link
Collaborator

@MexicanAce MexicanAce commented Jul 31, 2023

What 💻

  • Add configuration APIs to era-test-node documentation
  • Fix git pre-commit hooks

Why ✋

  • These are new APIs for era_test_node
  • They were not executable, and thus not working. After making them executable, I needed to update a file extension.

Evidence 📷

Link to Markdown changes: https://aqwzx-zksync-v2-docs--pr652-nicolasvillanueva-de-s02f9rnx.web.app/docs/tools/testing/era-test-node.html#replay-remote-transactions-locally

Pre-commit hooks working again:

$ git commit -m "chore: updates pre-commit hooks to be executable files"
→ No staged files match any configured task.
[nicolasvillanueva-devrl-174-add-configuration-api-to-in-memory-node 3b085928] chore: updates pre-commit hooks to be executable files
 2 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 .husky/commit-msg
 mode change 100644 => 100755 .husky/pre-commit

@MexicanAce MexicanAce requested a review from a team as a code owner July 31, 2023 15:57
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Visit the preview URL for this PR (updated for commit e5a4366):

https://aqwzx-zksync-v2-docs--pr652-nicolasvillanueva-de-s02f9rnx.web.app

(expires Mon, 07 Aug 2023 16:04:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec4de9998e9e17237caea0ab05986cdbc32c4efb

Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 87527f7 into main Jul 31, 2023
7 checks passed
@MexicanAce MexicanAce deleted the nicolasvillanueva-devrl-174-add-configuration-api-to-in-memory-node branch July 31, 2023 18:41
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This PR is included in version 1.5.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants