Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop - no default emojis #792

Closed
tdivis opened this issue Jan 26, 2023 · 8 comments
Closed

develop - no default emojis #792

tdivis opened this issue Jan 26, 2023 · 8 comments

Comments

@tdivis
Copy link

tdivis commented Jan 26, 2023

I compiled develop branch for fix in Thread view, but I noticed that all default emojis like (:+1:) are not available. Only custom emojis created by people in my team are available.

@jtdaugherty
Copy link
Member

Thanks for reporting this. It's now fixed on develop!

@binarious
Copy link

Having the same problem with matterhorn 50200.17.0 (master@7ca52c1).

@binarious
Copy link

And still with matterhorn 50200.18.0 (master@6de15ce).

@jtdaugherty
Copy link
Member

@binarious are you using one of the release binaries for 50200.18.0? And what platform are you using?

@jtdaugherty jtdaugherty reopened this Apr 21, 2023
@binarious
Copy link

@jtdaugherty I'm using matterhorn-50200.18.0-ubuntu-22.04-jammy-x86_64.tar.bz2 directly from https://github.com/matterhorn-chat/matterhorn/releases/tag/50200.18.0 on Arch Linux with Kernel 6.2.12.

@jtdaugherty
Copy link
Member

@binarious and anyone else affected by this: can you please provide the steps needed to reproduce this problem for you? I attempted to do so using our Darwin arm64 release and I didn't see any problems. Here is what I did, and the evidence I saw that indicates that the emoji data was loaded successfully:

  1. Unpack the release tarball that I wanted to run.
  2. Run matterhorn from within the release directory.
  3. Type :1 in the message input, then hit Tab.

At that point, the expected behavior, and the behavior that I actually observed, was that the completion list opened up with the following options at the top:

  :+1:
  :+1_dark_skin_tone:
  :+1_light_skin_tone:
  :+1_medium_dark_skin_tone:
  :+1_medium_light_skin_tone:

Here's another thing I did to confirm that the emoji data was loaded successfully:

  1. Select an existing message with C-s.
  2. Press a to open the emoji reaction list window.

The expected behavior, and the behavior I observed, is that the emoji list window that appeared started with the same emoji that were listed in the autocomplete example I posted above.

If anyone else is running into a problem with this, it would be very helpful to me if you can post steps to reproduce that show a behavior that differs from the above, or post steps to reproduce whatever you are doing, what you expect it to do, and what it actually does. Screenshots would also be very helpful, if you can provide them.

@binarious
Copy link

You are right. A fresh install seems to fix the problem.

@jtdaugherty
Copy link
Member

That's great to hear, @binarious - in that case, I'll close this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants