Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more manifest metadata #71

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Add more manifest metadata #71

merged 1 commit into from
Oct 13, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Oct 12, 2020

Summary

Add homepage_url and support_url to the manifest. support_url is not jet used in the webapp, but there is no downside of defining it already.

I've tested the changes locally and can confirm that the link to the homepage_url is correctly shown.

Ticket Link

Part of #69

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 12, 2020
@hanzei hanzei added this to the v0.2.2 milestone Oct 12, 2020
@hanzei hanzei mentioned this pull request Oct 12, 2020
Closed
3 tasks
@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #71 into master will increase coverage by 1.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   23.80%   25.39%   +1.58%     
==========================================
  Files           7        7              
  Lines         315      315              
==========================================
+ Hits           75       80       +5     
+ Misses        222      217       -5     
  Partials       18       18
Impacted Files Coverage Δ
server/manifest.go 100.00% <ø> (ø)
server/utils.go 87.87% <0.00%> (+15.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa5369...33d6848. Read the comment docs.

marianunez
marianunez approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanzei!

@hanzei hanzei requested review from larkox and removed request for jfrerich October 13, 2020 14:23
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 13, 2020
@hanzei
Copy link
Contributor Author

hanzei commented Oct 13, 2020

Let's skip QA review here and review the changes in the release process.

@hanzei hanzei merged commit 61fe029 into master Oct 13, 2020
@hanzei hanzei deleted the metadata branch October 13, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@marianunez marianunez marianunez approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @marianunez @larkox