-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix refresh token issue #9
Fix refresh token issue #9
Conversation
Added a new unit test
Added some validation while fetching grant type and refresh token from the request
Added the ability to refresh the token based on the grant type
Hi @Szymongib
|
Hey @DHaussermann, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks good. I think we should add a unit test for the new case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @manojmalik20! Looks good!
@DHaussermann I am going to merge it and deploy it to the Test environment, after that you should be able to test with |
@manojmalik20 I have tested this and I don't see the issue resolved. I spun up a server with cc @Szymongib unless I've misunderstood something - the change is being deployed when I spin up a cloud server now. Please advise. |
@DHaussermann just to make sure, you tested this with modified version of plugin from mattermost/mattermost-plugin-gitlab#298 right? |
@Szymongib I did not test with that specific PR branch but I tested with the |
@DHaussermann could you share plugin logs? Does it error in any way? |
Hi @Szymongib
I will post this on #10 so we have all the info and discussion in i place. |
Summary
Chimera didn't contain the functionality to refresh the OAuth token. This PR adds that functionality.
Related Links
mattermost/mattermost-plugin-gitlab#298
mattermost/mattermost-plugin-gitlab#298 (comment)