Fix confused cursor in HiDPI #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's working fine for me, but I was unable to reproduce the issue in the first place.. Would anyone else be interested helping test the PR for Windows? |
|
This should be good -- we'll test it once more on RC2 as well to verify. Thanks @yuya-oc! |
yuya-oc
added a commit
to yuya-oc/desktop
that referenced
this pull request
Mar 3, 2017
This reverts mattermost#384 (f60d1fe). Blur was a known side effect of mattermost#384 though, the original problem looks fixed in electron v1.6.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
Fix the issue where the mouse cursor is randomly incorrect when DPI is higher than 100% on Windows.
It was introduced by upgrading Electron in #307.
Issue link
#307 (comment)
electron/electron#7655
Test Cases
Set DPI higher than 100%, e.g. 150%, 175%. Then move mouse cursor across messages in a channel.
Background should not blink.
Additional Notes
Artifacts: https://circleci.com/gh/yuya-oc/desktop/103#artifacts