-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You have to click twice when a window is out of focus to have actions performed #534
Comments
Thanks @cetra3 for the report! We fixed a similar issue with #262 but that was a while ago. I also tried reproducing on Windows 10, and it seemed to be working for me. Would you like to download our newest release (desktop app v3.7) from our downloads page (https://about.mattermost.com/downloads) to confirm the latest release doesn't fix the issue? |
I've just given the new version a download. Same issue in |
True, it could be Mac specific. Just one more test case: when you click on the window, do keyboard shortcuts work for you (for instance, after clicking inside the app window, does CMD+K bring up channel switcher, or do you have to click inside the app twice before the shortcut works)? |
Yep, the channel switcher works fine after clicking into the window |
Thanks! That's helpful to know. We should have enough information to investigate the cause and whether it's something we can fix or if it's an Electron-related bug. |
Sorry for late. I think it's expected behavior in Electron. Basically the window should behave as well as Chrome. |
@jasonblais It's the same behaviour. Can this be switched off via some electron flag or something? |
Thanks @cetra3, doesn't look like it: electron/electron#5900 @yuya-oc There seems to be a potential workaround for it, but it wasn't working for everyone: electron/electron#5900 (comment) If the above workaround doesn't work, then there isn't much we can do. |
@jasonblais The workaround is already applied to our app. The issue is a little different from this. The point is that Electron's BrowserWindow requires a click before handling mouse events on macOS. And I think it looks consistent compared to Chrome. |
@cetra3 The Electron issue was closed without a fix. We don't have control to change this behaviour at the moment, given this is how it works on Chrome as well. So I'll regretfully have to close this issue as a Won't Fix. |
I confirm (by marking "x" in the [ ] below):
Summary
When the Mattermost window is not in focus, you have to click twice on any UI element to have that action performed.
For instance, change the channel or selecting a direct message.
Steps to reproduce
This is a simple one to reproduce:
Expected behavior
The click will perform the action to change the channel or direct message
Observed behavior
The desktop app is in focus, but the click is not registered, and you have to click again
Possible fixes
Not sure, might be an Electron related issue
The text was updated successfully, but these errors were encountered: